✅ remove unit test noise - #4673
Merged
Merged
Conversation
avoid noisy console output during yarn test:unit by stubbing display.error and display.warn in deliveryApi.spec.ts setup and reusing those spies in assertions.
stub display.warn in api.spec.ts setup and reuse the shared spy in assertions to avoid noisy console output during unit runs.
ensure stopSessionManager() tears down lifecycleTracker listeners to prevent leaked listeners across tests and repeated session manager lifecycles.
stub console.error in bufferedData.spec.ts so the test still validates console log buffering without printing noisy test output.
replace placeholder image/source src and srcset values with data URLs in serializeAttributes.spec.ts to avoid noisy 404 requests during unit test runs.
Bundles Sizes Evolution
|
BenoitZugmeyer
marked this pull request as ready for review
May 26, 2026 13:17
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 11dd139 | Docs | Datadog PR Page | Give us feedback! |
BenoitZugmeyer
changed the title
thomas-lebeau
approved these changes
May 26, 2026
bdibon
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Running the unit test suite produced noisy, non-actionable console output, which made it harder to spot real failures quickly.
Changes
console.erroroutput in the buffered data console test while preserving assertions.src/srcsetvalues with data URLs in serialization tests to avoid noisy 404 requests.Test instructions
yarn test:unitChecklist